Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Windows tests from CI #163

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

zacharyburnett
Copy link
Collaborator

closes #162

since jwst and romancal and hstcal do not support Windows, we might as well stop testing on Windows here

@zacharyburnett zacharyburnett self-assigned this Jun 26, 2024
@zacharyburnett zacharyburnett requested a review from a team as a code owner June 26, 2024 18:28
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (e074807) to head (c9c75de).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   69.83%   69.83%           
=======================================
  Files          24       24           
  Lines        1618     1618           
=======================================
  Hits         1130     1130           
  Misses        488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator

Thanks! Would you also add a note to the readme similar to jwst and romancal:

> [!NOTE]
> Linux and MacOS platforms are tested and supported.  Windows is not currently supported.

and a changelog entry?

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacharyburnett zacharyburnett merged commit 01f1956 into spacetelescope:main Jun 27, 2024
15 of 16 checks passed
@zacharyburnett zacharyburnett deleted the remove/windows branch June 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of os.uname causes failures on windows
2 participants