WIP: more cleanup #155
Draft
WIP: more cleanup #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
braingram
commented
Jun 12, 2024
•
braingram
commented
- remove _check_args and DISCOURAGED_TYPES
- duck-typing in save
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 69.83% 70.06% +0.22%
==========================================
Files 24 24
Lines 1618 1597 -21
==========================================
- Hits 1130 1119 -11
+ Misses 488 478 -10 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
discouraged_types
branch
from
66cb508
to
92bedab
Compare
Open
braingram
force-pushed
the
discouraged_types
branch
from
92bedab
to
c21b3fb
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.