Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of os.uname causes failures on windows #162

Closed
braingram opened this issue Jun 25, 2024 · 0 comments · Fixed by #163
Closed

Use of os.uname causes failures on windows #162

braingram opened this issue Jun 25, 2024 · 0 comments · Fixed by #163

Comments

@braingram
Copy link
Collaborator

os.uname does not exist on windows. It's usage in this package:

stpipe/src/stpipe/cmdline.py

Lines 350 to 351 in 915a832

log.log.info(f"Hostname: {os.uname()[1]}")
log.log.info(f"OS: {os.uname()[0]}")

causes failures on windows:
https://github.com/spacetelescope/stpipe/actions/runs/9637434273/job/26576657996#step:10:400

Some clarification on if we support windows (romancal and jwst do not) would be helpful. If we do support windows we'll need a replacement for os.uname. If we do not support windows we could disable the windows tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove Windows tests from CI zacharyburnett/stpipe
1 participant
@braingram