Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for each with concurrency #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chebyte
Copy link

@chebyte chebyte commented Jul 8, 2015

  • Adds each_with_concurrency method
  • Updates Readme

  * Adds each_with_concurrency method
  * Updates Readme
@seivan
Copy link

seivan commented Apr 11, 2017

@scalp42 @chebyte Sorry for waking this up, but I'm doing some research on how to use Redis with a distributed lock for queues and I was wondering, how does this PR handle removing from the backup queue? In a perfect world order wouldn't matter and if you process 5 items, then 5 will be popped. But in scenarios where exceptions are thrown you might pop the wrong items.

@seivan
Copy link

seivan commented Apr 11, 2017

I see that this commit is missing https://github.com/soveran/ost/pull/8/files#diff-e007f35caa5af71683eeaa305ba27a2cR38 that would make this actually work. But then you'd remove specific items instead of popping the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants