Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8 pass #1

Merged
merged 1 commit into from
Apr 7, 2015
Merged

pep8 pass #1

merged 1 commit into from
Apr 7, 2015

Conversation

bignaux
Copy link

@bignaux bignaux commented Apr 7, 2015

No description provided.

@souvik1997
Copy link
Owner

Thanks for the pull request. Did you manually edit the file to comply with pep8 or did you use a program?

I'm asking because the diff is huge.

@souvik1997
Copy link
Owner

Additionally, your file doesn't follow E501 (line too long error).

@bignaux
Copy link
Author

bignaux commented Apr 7, 2015

i manually did it after pydev formatting (tab spacing). I'm ignoring E501 since i'm not totally agree with 80 char limitation ... It's huge because you were using tab spacing. There is still some work, like 'type' variable, a reserved keyword, useless import. But i prefer see step by step how contributions are received before spend too much time. This patch contains no change code.

@souvik1997
Copy link
Owner

Thanks for the contribution!

souvik1997 added a commit that referenced this pull request Apr 7, 2015
@souvik1997 souvik1997 merged commit b0b7986 into souvik1997:souvik Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants