Fix alerts on team members page #63411
Assignees
Comments
taras-yemets
added a commit
that referenced
this issue
Jun 20, 2024
Closes #63234 [Design](https://www.figma.com/design/FMSdn1oKccJRHQPgf7053o/Cody-PLG-GA?node-id=5556-13856&t=f13ek1ZSgoUdrH6z-0) Adds a button to remove the remaining invites from a subscription. https://github.com/sourcegraph/sourcegraph/assets/25318659/679e19dd-0e0e-4561-8ac1-af1b6979ee73 **Known deviation from design (cc: @rrhyne)** The “Remove User” success message and the “Remove Seats from Subscription” alerts are positioned differently than in the design. The “Remove User” banner, along with other user and invite list alerts, is placed above the users list, below the page title or the invites textbox if rendered. The “Remove Seats from Subscription” banner, along with other invite textbox alerts, is located above the invites textbox instead of above the page title and all the page content. These issues will be addressed in follow-up PRs, as we need to refactor the existing Team Members page layout. Created an issue to address it: - #63411 <!-- 💡 To write a useful PR description, make sure that your description covers: - WHAT this PR is changing: - How was it PREVIOUSLY. - How it will be from NOW on. - WHY this PR is needed. - CONTEXT, i.e. to which initiative, project or RFC it belongs. The structure of the description doesn't matter as much as covering these points, so use your best judgement based on your context. Learn how to write good pull request description: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e?pvs=4 --> ## Test plan - Run a Sourcegraph instance in dotcom mode - Sign in as a team admin - Ensure there are free seats on your team (invites remaining) - Ensure "Remove invites from plan" button is rendered - Check the number of invites remaining - Click the button - Ensure the subscription has been updated and now the max seats reduced by the number of remaining invites - Ensure the success banner is rendered <!-- All pull requests REQUIRE a test plan: https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog <!-- 1. Ensure your pull request title is formatted as: $type($domain): $what 2. Add bullet list items for each additional detail you want to cover (see example below) 3. You can edit this after the pull request was merged, as long as release shipping it hasn't been promoted to the public. 4. For more information, please see this how-to https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c? Audience: TS/CSE > Customers > Teammates (in that order). Cheat sheet: $type = chore|fix|feat $domain: source|search|ci|release|plg|cody|local|... --> <!-- Example: Title: fix(search): parse quotes with the appropriate context Changelog section: ## Changelog - When a quote is used with regexp pattern type, then ... - Refactored underlying code. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Alerts related to the Invite component (invite textbox) and the Members & Invite list are positioned differently than in the design.
• Alerts for the Members & Invite list are placed above the users list, below the page title or the invites textbox if rendered.
• Alerts for the Invite component are located above the invites textbox instead of above the page title and all the page content.
See also #63408
The text was updated successfully, but these errors were encountered: