Display update state in UI #919
Conversation
nicksnyder
commented
Nov 10, 2018
da17e5c
to
29c13a0
Compare
| @@ -29,6 +29,7 @@ class UpdateMirrorRepositoryActionContainer extends React.PureComponent<UpdateMi | |||
| private subscriptions = new Subscription() | |||
|
|
|||
| public componentDidMount(): void { | |||
| // TODO rxjs medic, I just want this to continuously poll | |||
There was a problem hiding this comment.
@felixfbecker what do I need to do if I want this to refresh every N seconds while the component is visible?
There was a problem hiding this comment.
Looks like rn it polls only while clone in progress. I think you just need to remove the takeUntil
There was a problem hiding this comment.
I simplified this a lot; can you please take a look?
There was a problem hiding this comment.
Honestly I don't understand the code. To poll, it just calls onDidUpdateRepository(), which doesn't have any docblock describing what its purpose is. If this repository gets the repo from the parent I don't understand why it would handle polling instead of the parent, and I don't understand why this is an event described as "the repository did update" when it is triggering an update.
There was a problem hiding this comment.
I agree that in absolute terms, the interaction here is confusing. From a diff perspective, I just deleted code and it seems to do what I want, so I am going to merge.
29c13a0
to
1305190
Compare
Codecov Report
|