Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Reapply "soap: Fix auto-redirect to IdP when SOAP is enabled" (#64234) #64244

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

eseliger
Copy link
Member

@eseliger eseliger commented Aug 2, 2024

This reverts commit https://github.com/sourcegraph/sourcegraph/commit/81585cb7ca98196695088d3b1a1038606ef2bcde.

Test plan

Tested in dotcom mode locally after clearing cookies and no redirect happens now.

@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
@eseliger eseliger requested a review from a team August 2, 2024 11:30
@github-actions github-actions bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Aug 2, 2024
Copy link
Contributor

@pjlast pjlast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe just ask for a short comment like // Don't auto-redirect to sign-in when site is publicly accessible but other than that looks good

@eseliger eseliger force-pushed the es/reintroduce-auth-redirect branch from e06c33a to 6d6c7ad Compare August 2, 2024 12:13
@eseliger
Copy link
Member Author

eseliger commented Aug 2, 2024

done!

@eseliger eseliger enabled auto-merge (squash) August 2, 2024 12:13
@eseliger eseliger merged commit ad4d717 into main Aug 2, 2024
13 checks passed
@eseliger eseliger deleted the es/reintroduce-auth-redirect branch August 2, 2024 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants