This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Language support via Sourcegraph extensions #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bcdfd3
to
5cc0db5
Compare
cc @slimsag |
ebc2813
to
fd1b2f1
Compare
2775f62
to
89a6c0c
Compare
80b144a
to
b1de5c9
Compare
sqs
referenced
this pull request
Nov 14, 2018
…thub.com/sourcegraph/sourcegraph/pkg/vfsutil This prepares for the removal of xlang (sourcegraph/sourcegraph#584).
687724c
to
e6b6de8
Compare
b9f907a
to
dee12a8
Compare
This was referenced Dec 3, 2018
sqs
added a commit
that referenced
this pull request
Dec 4, 2018
- Adds UI support for showing external references from extensions. External references are now shown in the same panel as local references. If a reference is emitted that is from a different repo, another column will show up to let the user select the repo. The current repo is always at the top and initially selected. - Adds a "Group by file"/"Ungroup by file" panel action that adds in another column to filter references by file. Extensions can add other things here, such as toggling on/off certain reference providers. - Adds a new `sourcegraph.languages.registerLocationProvider` call that generalizes location providers and panels. This can be used to show locations that are neither definitions nor references (such as implementations, type definitions, etc.). This is part of #1187 and a requirement for deploying #584 to Sourcegraph.com (the switchover to the new extension-based code intel).  
251b07c
to
4481f58
Compare
be138cb
to
0868e34
Compare
The `sourcegraph-langserver-http` repository's Sourcegraph extension was previously used as the extension for all language servers present in the site configuration `langservers` property. This commit makes it so that Sourcegraph no longer synthesizes extensions for these languages.
This commit makes it so language servers, cross-repository refs/defs/deps/packages search, and all other code intelligence features are provided by extensions only. BREAKING CHANGE NOCHANGELOG
0747bd9
to
b74767e
Compare
BolajiOlajide
pushed a commit
that referenced
this pull request
Apr 16, 2024
The test `TestInferRepo` unnecesarily depends on the root being a git repository. This change updates `TestInferRepo` to create a fresh git repo in a temporary dir. Why? I want to add src-cli to the nixos package repository. During the build stage, nixos downloads a tar of the repo. The tar, however, is not a git repo and thus `TestInferRepo` fails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://sourcegraph.slack.com/archives/CCLF4R6EM/p1540856089027900 for context.
TODOs
/go/-/...) and godoc.org links still workFile a followup issue to remove thehttps://github.com/sourcegraph/sourcegraph/issues/644repo.indexed_revisionandrepo.freeze_indexed_revisioncolumns laterqueryLSPfrom@sourcegraph/extensions-client-commonAssess consequences of removing noGoGetDomains and thehttps://github.com/sourcegraph/sourcegraph/issues/1276go getdomains blacklist - add back to Go extensionFind an alternative data source for badges (ref count)isEmptyHover,renderHoverContents