This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Enable external services by default and update documentation #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… frontend/graphqlbackend so that it can call the database to get the external services config
tsenart
reviewed
Dec 12, 2018
tsenart
approved these changes
Dec 12, 2018
nicksnyder
commented
Dec 12, 2018
| } | ||
| } | ||
| return GQL.ExternalServiceKind.GITHUB | ||
| })(), |
There was a problem hiding this comment.
@felixfbecker I am going to merge this PR soon, but I would appreciate your review on this particular snippet. I need this component to respond to a url query parameter. This works, but I don't know if there is a more idiomatic way to do this.
There was a problem hiding this comment.
The code LGTM, but this only gets evaluated on component instantiation and not when this.props.history.location.search changes. I don't see kind being changed anywhere, so I would recommend to remove this state field and call this as a function.
There was a problem hiding this comment.
Codecov Report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/sourcegraph/sourcegraph/issues/914#issuecomment-440067022