Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current config/fontconfig is incorrect. Fontconfig deletes the first matched font family. Therefore, it actually unsets the "Hack" family instead of the "sans-serif" family.
Evidence: on my machine, after applying the upsteam 45-Hack.conf, "fc-match -s Hack" returns:
It doesn't even return Hack match, because it is deleted.
After applying the 45-Hack.conf in this PR, "fc-match -s Hack" returns:
It returns both Hack and other monospace fonts, which is the correct behavior.