Sourcery refactored master branch #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ | |||
| LICENSE file in the root directory of this source tree. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 19-20 refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-63
to
+66
| logging.info("Using CUDA: {} CUDA AVAIL: {} #DEVICES: {} VERSION: {}".format( | ||
| args.cuda, torch.cuda.is_available(), torch.cuda.device_count(), | ||
| torch.version.cuda)) | ||
| logging.info( | ||
| f"Using CUDA: {args.cuda} CUDA AVAIL: {torch.cuda.is_available()} #DEVICES: {torch.cuda.device_count()} VERSION: {torch.version.cuda}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function BaseTrainer.initial_setup refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-111
to
+112
| indices = range(0, ndev) | ||
| indices = range(ndev) |
There was a problem hiding this comment.
Function BaseTrainer.data_setup refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
Comment on lines
-153
to
+154
| logging.info("Train Loader created, batches: {}".format(self.nbatches)) | ||
| logging.info(f"Train Loader created, batches: {self.nbatches}") |
There was a problem hiding this comment.
Function BaseTrainer.loader_setup refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-170
to
+180
| self.runinfo = {} | ||
| self.runinfo["args"] = args | ||
| self.runinfo["at_epoch"] = 0 | ||
| self.runinfo["seed"] = args.seed | ||
| self.runinfo["best_dev_loss"] = 1e9 | ||
| self.runinfo["epoch"] = [] | ||
| self.runinfo["train_losses"] = [] | ||
| self.runinfo["train_fnames"] = [] | ||
| self.runinfo["dev_losses"] = [] | ||
| self.runinfo = { | ||
| "args": args, | ||
| "at_epoch": 0, | ||
| "seed": args.seed, | ||
| "best_dev_loss": 1000000000.0, | ||
| "epoch": [], | ||
| "train_losses": [], | ||
| "train_fnames": [], | ||
| "dev_losses": [], | ||
| } |
There was a problem hiding this comment.
Function BaseTrainer.runinfo_setup refactored with the following changes:
- Merge dictionary assignment with declaration [×8] (
merge-dict-assign)
Comment on lines
-91
to
+99
| group_idx = 0 | ||
| nlayers = 0 | ||
| for param in model.parameters(): | ||
| group_size = 1 | ||
| for g in param.size(): | ||
| group_size *= g | ||
| nparams += group_size | ||
| group_idx += 1 | ||
| if len(param.shape) >= 2: | ||
| nlayers += 1 | ||
|
|
There was a problem hiding this comment.
Function LoggingMixin.count_parameters refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Replace manual loop counter with call to enumerate (
convert-to-enumerate) - Remove unnecessary calls to
enumeratewhen the index is not used (remove-unused-enumerate)
| @@ -5,14 +5,15 @@ | |||
| LICENSE file in the root directory of this source tree. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 15-15 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| @@ -5,6 +5,7 @@ | |||
| LICENSE file in the root directory of this source tree. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 19-19 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-104
to
+111
| print(f"Received USR1 signal in spawn_dist", flush=True) | ||
| print("Received USR1 signal in spawn_dist", flush=True) | ||
| for i, p in enumerate(processses): | ||
| if p.is_alive(): | ||
| os.kill(p.pid, signal.SIGUSR1) | ||
|
|
||
| def forward_term_signal(signum, frame): | ||
| print(f"Received SIGTERM signal in spawn_dist", flush=True) | ||
| print("Received SIGTERM signal in spawn_dist", flush=True) |
There was a problem hiding this comment.
Function run refactored with the following changes:
- Replace f-string with no interpolated values with string [×2] (
remove-redundant-fstring)
Comment on lines
-164
to
+165
| losses['instantaneous_' + name] = loss_dict[name] | ||
| losses['average_' + name] = avg_losses[name] | ||
| losses[f'instantaneous_{name}'] = loss_dict[name] | ||
| losses[f'average_{name}'] = avg_losses[name] |
There was a problem hiding this comment.
Function TrainingLoopMixin.run refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!