Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to resolve ambiguity with Base #9

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Add methods to resolve ambiguity with Base #9

merged 2 commits into from
Jun 18, 2020

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jun 13, 2020

Added methods to // to resolve ambiguity involving Complex numbers and AbstractArrays. Also added a test to ensure that ambiguities do not creep in.

Added methods to // to resolve ambiguity involving Complex
numbers and Arrays
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #9 into master will decrease coverage by 6.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   97.51%   91.46%   -6.06%     
==========================================
  Files           1        1              
  Lines         161      164       +3     
==========================================
- Hits          157      150       -7     
- Misses          4       14      +10     
Impacted Files Coverage Δ
src/HalfIntegers.jl 91.46% <100.00%> (-6.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc35b2...6a07724. Read the comment docs.

@sostock
Copy link
Owner

sostock commented Jun 14, 2020

Thanks for the PR!

The test failures on nightly are due to JuliaLang/julia#35483 and JuliaLang/julia#35492, which changed the return type of *(::Rational, ::Integer) and *(::Integer, ::Rational). I have opened an issue here: JuliaLang/julia#36277. If that isn’t resolved, I would be in favor of just relaxing the tests to not check for the return type.

src/HalfIntegers.jl Outdated Show resolved Hide resolved
@sostock
Copy link
Owner

sostock commented Jun 18, 2020

Now that JuliaLang/julia#36279 is merged (and will be backported to 1.5), this should be good.

@sostock sostock merged commit 38e9cfb into sostock:master Jun 18, 2020
@jishnub jishnub deleted the ambiguity branch June 19, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants