Geometer: use a lower-bound threshold for "at level" operation #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining compiler warning for me in our codebase has been this unused variable level in Geometer. Looking at it in context, I think the intention was to provide a lower-bounds audio threshold within which the "between" state for "at level" point generation is detected? I think without this and with the point parameter slider at its minimum, an audio sample is only "between" when it is exactly zero, and then with this scaling anything between -.00005 and .00005 (about -86 dB) will be deemed "between".
I played around both ways, and honestly I couldn't hear a difference with the audio material I was using. But I'm not really sure what the auditory effect of the "between" state is supposed to sound like.
I'm guessing that either you played with having the .00005 threshold and then changed your mind, or wanted the .00005 threshold and then didn't actually integrate it into the logic, but I'm not sure which! If it already is as intended, then I'll just update this PR to delete the unused variable instead.
Anyway, just very minor tidying, but thought to run it by you if you have any memory or opinions on this.