MIDI Gater: add a low-pass gate mode #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es between that and amplitude gating)
sophiapoirier
force-pushed
the
midigater_lpg
branch
from
8fdd645
to
9c82cb0
Compare
|
I actually am going to merge this because I have a follow-up that will be conflict-y, but of course will be possible to fix any problems later if found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature I have been scheming on for a while, finally got to implementing it.
I made PR primarily because I touched many Windows build files and also added to MIDI Gater GUI and would love to know if the three new buttons (two common MIDI learn ones and one new "gate mode" parameter) appear properly, though you are also of course welcome to review as much or as little beyond that as may interest you. The reason why so many project files were touched is because I made DfxEnvelope now pull in IIRFilter, and DfxMidi already pulls in DfxEnvelope, so this means that now every MIDI-using plug needs iirfilter.cpp