Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive Windows DLL versioning #22

Closed
sophiapoirier opened this issue Oct 7, 2020 · 0 comments
Closed

revive Windows DLL versioning #22

sophiapoirier opened this issue Oct 7, 2020 · 0 comments
Assignees

Comments

@sophiapoirier
Copy link
Owner

sophiapoirier commented Oct 7, 2020

Once upon a time, I had version metadata properly imbued into the Windows plugin DLLs using the file dfx-library/dfxplugin-version.rc. It could pre-process the *-def.h prefix header files (and relied on some macros defined in those to populate the version info), and so it would involve adding something like this into the win32/resource.rc files:

#include "geometer-def.h"
#include "../../dfx-library/visualstudio/dfxplugin-version.rc"

Perhaps if interested, you could see whether it might be easy enough to reintegrate this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants