Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1-Stock-Data.md #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 1-Stock-Data.md #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion 9-System-Design-And-Scalability/1-Stock-Data.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,18 @@ even if this wasn't a procedure we "expected" them to need.

So which one of these would we use? There's no clear answer. The pure text file solution is probably a
bad choice, but you can make a compelling argument for the SQL or XML solution, with or without a web
service.
service.

**#Proposal 4**

The clients can send a GraphQL query to the API we created, and then get exactly what they need, nothing more nothing less.
Advantages
- all the data needed by client can be fetched in a single request.
- GraphQL queires are quick evenon slow mobile connections
- Manual parsing errors with XML can be avoided
- new fields and types can be added without impacting existing queries
- not limited to a specific storage engine

Disadvantages
- No rate limiting option. That is, in REST API, you can simply specify that we allow only this amount of requests in one day", but in GraphQL, it is difficult to specify this type of statement.
- GraphQL is a simple query language. So there must be a mechanism like maximum query depths, query complexity weighting, avoiding recursion, or persistent queries to stop inefficient requests from the client-side.