Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JRE and reduced custom config #51

Merged
merged 1 commit into from
Nov 4, 2016

Conversation

bradbeck
Copy link
Contributor

@bradbeck bradbeck commented Nov 1, 2016

Updated to the latest JRE. Reduced the custom configuration while maintaining the /nexus-data volume.

@bradbeck bradbeck force-pushed the update-jre-and-config-cleanup branch from 1f04ac8 to 7a6fa3c Compare November 1, 2016 20:02
@DarthHater
Copy link
Member

+1, tested and seems to work fine

@joedragons
Copy link
Contributor

+1

NEXUS_DATA=/nexus-data \
NEXUS_CONTEXT=''
NEXUS_CONTEXT='' \
SONATYPE_WORK=${SONATYPE_DIR}/sonatype-work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? I would expect this to be in NEXUS_DATA and not within the NEXUS_HOME dir, unless I'm misunderstanding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the idea is to leave KARAF_DATA configured as ../sonatype-work/nexus3 and instead symlink ${NEXUS_DATA} as ${SONATYPE_WORK}/nexus3 - rather than change KARAF_DATA which involves updating several entries in nexus.vmoptions (because that file doesn't support property interpolation).

If install4j ever added property interpolation to nexus.vmoptions that would avoid the need to update entries to reflect the new property value, but for now we either need to edit it wholesale or take Brad's symlink approach.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellyrob99 Note SONATYPE_WORK is effectively /opt/sonatype/sonatype-work and is not within NEXUS_HOME which is effectively /opt/sonatype/nexus.

@kellyrob99
Copy link
Member

+1

@DarthHater DarthHater merged commit cd24b0a into master Nov 4, 2016
@DarthHater DarthHater deleted the update-jre-and-config-cleanup branch November 4, 2016 18:15

RUN useradd -r -u 200 -m -c "nexus role account" -d ${NEXUS_DATA} -s /bin/false nexus \
&& mkdir -p ${NEXUS_DATA}/etc ${NEXUS_DATA}/log ${NEXUS_DATA}/tmp ${SONATYPE_WORK} \
&& ln -s ${NEXUS_DATA} ${SONATYPE_WORK}/nexus3 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symlink means that data is written to /opt/sonatype/sonatype-work/nexus3. I believe this forces users to have a docker volume at /opt/sonatype/sonatype-work rather than /nexus-data like the docs suggest. Is this intentional?

Copy link
Contributor Author

@bradbeck bradbeck Apr 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still use /nexus-data:

docker run -v /some/local/dir:/nexus-data sonatype/nexus3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wilfred Out of the box NXRM writes to /sonatype-work/nexus3. I believe the link has the inverse affect you're suggesting. It's taking stuff from where we write by default and putting into ${NEXUS_DATA}. I defer to the author however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants