NEXUS-11119 - Nexus 3.1 layout changes #50
Conversation
| && sed \ | ||
| -e "s|nexus-context-path=/|nexus-context-path=/\${NEXUS_CONTEXT}|g" \ | ||
| -i /opt/sonatype/nexus/etc/org.sonatype.nexus.cfg | ||
| -i ${NEXUS_DATA}/etc/nexus.properties |
There was a problem hiding this comment.
Any reason not to make this change directly in nexus-default.properties, rather than making changes to what may be an external filesystem at runtime? If the user maps NEXUS_DATA then these changes will be lost.
There was a problem hiding this comment.
Main reason was consistency with other documentation - nexus-default.properties contains the original defaults, whereas nexus.properties contains customized values.
We could always add a check to skip that part if nexus.properties file already exists.
There was a problem hiding this comment.
e.g. the following does not pick up the context change with the current image:
docker run --rm -p 8081:8081 -it -e NEXUS_CONTEXT=nexus -v ~/nexus-data:/nexus-data sonatype/docker-nexus3
There was a problem hiding this comment.
nexus-default.properties is probably safer though: 85fe6e5 - WDYT?
| # configure nexus runtime | ||
| ENV NEXUS_VERSION=3.1.0-04 \ | ||
| NEXUS_HOME=/opt/sonatype/nexus \ | ||
| NEXUS_DATA=/nexus-data \ |
There was a problem hiding this comment.
Thoughts on changing this to be /opt/sonatype/sonatype-work/nexus3 and forego the following changes to nexus.vmoptions?
There was a problem hiding this comment.
The current setup makes it easier for people to customize NEXUS_DATA so I'd prefer to keep that. It also provides a reference of which properties need adjusting for a custom data directory.
There was a problem hiding this comment.
NEXUS_DATA gets substituted with the actual path at image build time, so the user can't override it at container run time (e.g. -e NEXUS_DATA=/foo/bar). It only makes the path to which they map a bit shorter (i.e. -v ~/nexus-data:/nexus-data vs. -v ~/nexus-data:/opt/sonatype/sonatype-work/nexus3). I'm ok with leaving as /nexus-data for compatibility with earlier versions. Not sure it makes the image any more flexible and introduces what maybe unnecessary configuration massaging.
|
+1 and validated that the image runs fine locally (note i can't actually click the approve button since i opened the PR) |
rather than ${NEXUS_DATA}/etc/nexus.properties in case ${NEXUS_DATA}
is mapped to an external filesystem.
|
Hey guys, Could you please update the image on the docker hub please? Great to see an update!!! |
|
@kachkaev See https://hub.docker.com/r/sonatype/docker-nexus3/, I believe that's what you want. |
|
@joedragons Thank you! Just wondering why there is sonatype/docker-nexus3 and sonatype/nexus3 on Docker Hub. Looks redundant to me? |
|
@alexbde Yep, we moved fairly recently, I am persuing. Thanks=) |
|
@alexbde the newer image was setup so we could use the automated build feature. Please treat the other as deprecated for now. |
|
@DarthHater I'll do 👍 Maybe you can leave a hint or something at sonatype/nexus3 for others finding that repo via Google (: |
|
Totally confused folks:
Where can I find the current one? |
|
@kdekooter https://hub.docker.com/r/sonatype/nexus3/ This also confuses me a lot. Interesting, that the deprecated copy was updated more recently than the master one. |
|
Issue #56 sheds some more |
Updated to use 3.1 release and new directory layout