Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications to ENV variables to follow best practices #41

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Modifications to ENV variables to follow best practices #41

merged 1 commit into from
Oct 14, 2016

Conversation

DarthHater
Copy link
Member

Follows best practices from: https://docs.docker.com/engine/reference/builder/#env to reduce number of layers, help with cache invalidation per #18

@DarthHater DarthHater mentioned this pull request Oct 14, 2016
Closed
bentmann
bentmann approved these changes Oct 14, 2016
View reviewed changes
Copy link

@bentmann bentmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

bradbeck
bradbeck approved these changes Oct 14, 2016
View reviewed changes
Copy link
Contributor

@bradbeck bradbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@DarthHater DarthHater merged commit be84bce into master Oct 14, 2016
@DarthHater DarthHater deleted the EnvCommandBestPractice branch October 14, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentmann bentmann bentmann approved these changes

@bradbeck bradbeck bradbeck approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@DarthHater @bentmann @bradbeck