Fabdouglas patch 1 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an ENV to configure initial context and avoid a manual step either with a "docker exec" either with a temporary UI access with root (/) context to change it. Default value of NEXUS_CONTEXT is "/".
…into fabdouglas-patch-1
- use ENV variable in replacement
- fix doubling of contexts path in regex - properly escape variable definition for NEXUS_CONTEXT
DarthHater
approved these changes
Oct 13, 2016
| RUN sed \ | ||
| -e "s|karaf.home=.|karaf.home=/opt/sonatype/nexus|g" \ | ||
| -e "s|karaf.base=.|karaf.base=/opt/sonatype/nexus|g" \ | ||
| -e "s|karaf.etc=etc|karaf.etc=/opt/sonatype/nexus/etc|g" \ | ||
| -e "s|java.util.logging.config.file=etc|java.util.logging.config.file=/opt/sonatype/nexus/etc|g" \ | ||
| -e "s|karaf.data=data|karaf.data=${NEXUS_DATA}|g" \ | ||
| -e "s|java.io.tmpdir=data/tmp|java.io.tmpdir=${NEXUS_DATA}/tmp|g" \ | ||
| -i /opt/sonatype/nexus/bin/nexus.vmoptions | ||
| -i /opt/sonatype/nexus/bin/nexus.vmoptions \ | ||
| && sed \ |
There was a problem hiding this comment.
I'm mildly ignorant, but do you need another sed being it's already being used?
There was a problem hiding this comment.
different file, different command
|
An example usage of |
bradbeck
approved these changes
Oct 13, 2016
Add an ENV to configure initial context and avoid a manual step either with a "docker exec" either with a temporary UI access with root (/) context to change it. Default value of NEXUS_CONTEXT is "/".
- use ENV variable in replacement
- fix doubling of contexts path in regex - properly escape variable definition for NEXUS_CONTEXT
…er-nexus3 into fabdouglas-patch-1
|
@bradbeck added documentation |
bradbeck
reviewed
Oct 13, 2016
| @@ -55,6 +55,15 @@ process, which runs as UID 200. | |||
| $ docker run -d -p 8081:8081 --name nexus -e JAVA_MAX_HEAP=768m sonatype/docker-nexus3 | |||
| ``` | |||
|
|
|||
| * Another environment variable can be used to control the Nexus Context Path | |||
|
|
|||
| * `NEXUS_CONTEXT`, defaults to \ | |||
There was a problem hiding this comment.
Strictly speaking, it defaults to the empty string.
- fix incorrect slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected version of #19