Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Docker-nexus3 license as ASLv2 #33

Merged
merged 11 commits into from
Oct 4, 2016
Merged

Specify Docker-nexus3 license as ASLv2 #33

merged 11 commits into from
Oct 4, 2016

Conversation

DarthHater
Copy link
Member

No description provided.

@kellyrob99
Copy link
Member

+1 if @brianf says Apache is the way to go here

@jswank jswank merged commit 3be88b6 into sonatype:master Oct 4, 2016
FROM centos:centos7
MAINTAINER Sonatype <[email protected]>
LABEL vendor=Sonatype \
com.sonatype.license="ASLv2" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an accepted license name. The full name is Apache License, Version 2.0 [0] and the short name is Apache License 2.0.

[0] http:https://www.apache.org/licenses/

FROM centos:centos7
MAINTAINER Sonatype <[email protected]>
LABEL vendor=Sonatype \
com.sonatype.license="ASLv2" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It the label com.sonatype.license appropriate for indicating the license of this Docker file? Elsewhere I've only seen a label of license. I don't know what attribute tools use to extract the license.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did com.sonatype.license as that is consistent with how Docker suggests to add labels, particularly to avoid collision (which we were experiencing to some degree since we use centos): https://docs.docker.com/v1.8/userguide/labels-custom-metadata/

docker inspect is one way to view the license information of an image, which will give you much more info. I'm unsure what else is used, if anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants