This repository has been archived by the owner on May 27, 2022. It is now read-only.
forked from phadej/igbinary
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use a string index count instead of hash size as string ids.
The string serailizers (object name and string) assigned strings ids based on the duplicate strings hash size. Because compact_strings only applies to strings and not objects the string index could go out of sync. During deserialization object name id:s incorrectly back reference to normal strings, causing creation of "incomplete classes" etc.
- Loading branch information
Showing
2 changed files
with
68 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
--TEST-- | ||
Object serialization with compact strings | ||
--SKIPIF-- | ||
<?php | ||
if (!extension_loaded("igbinary")) { | ||
print "skip"; | ||
} | ||
?> | ||
--INI-- | ||
igbinary.compact_strings=Off | ||
--FILE-- | ||
<?php | ||
class Foo { | ||
} | ||
|
||
class Bar { | ||
} | ||
|
||
|
||
$expected_array = array(); | ||
for ($i = 0; $i < 10; $i++) { | ||
$expected_array['foo_' . $i] = new Foo; | ||
$expected_array['bar_' . $i] = new Bar; | ||
} | ||
|
||
$actual_array = igbinary_unserialize(igbinary_serialize($expected_array)); | ||
|
||
$error = 'OK'; | ||
|
||
foreach ($expected_array as $key => $object) { | ||
if (!isset($actual_array[$key])) { | ||
$error = 'ERROR'; | ||
echo "Key $key is missing from result.\n"; | ||
echo "Expected key/value:\n"; | ||
var_dump($key, $object); | ||
var_dump($object); | ||
|
||
break; | ||
} | ||
|
||
if (!is_object($actual_array[$key]) || | ||
get_class($object) !== get_class($actual_array[$key])) { | ||
$error = 'ERROR'; | ||
echo "Array mismatch on $key\n"; | ||
echo "Expected key/value:\n"; | ||
var_dump($key, $object); | ||
echo "Actual key/value:\n"; | ||
var_dump($key, $actual_array[$key]); | ||
|
||
break; | ||
} | ||
|
||
} | ||
|
||
echo $error, "\n"; | ||
|
||
--EXPECT-- | ||
OK |