Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual cache checks w/ require_dependency #39

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jan 7, 2020

That's the correct (Rails) way of requiring in production and loading
when needed by the cache settings.

Fixes #34

That's the correct (Rails) way of requiring in production and loading
when needed by the cache settings.

Fixes solidusio#34
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thanks 👏

@spaghetticode spaghetticode merged commit 523db53 into solidusio:master Jan 8, 2020
@spaghetticode spaghetticode deleted the elia/require-dependency branch January 8, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use require_dependency instead of require/load
3 participants