Minimum cancellation date is always +1 day from what you set it to

[seand7565]

# app/models/solidus_subscriptions/subscription.rb

(actionable_date - SolidusSubscriptions.configuration.minimum_cancellation_notice).future?

If your minimum_cancellation_notice is set to one day, I would expect to not be able to cancel on the same day as the actionable_date, but I should be able to cancel the day before. However, because of the above code, I can't cancel on the day the subscription processes or the day before, effectively making the minimum cancellation notice 2 days, even though it's set as one.

(Date.tomorrow - 1.day).future?
# => false

Additionally, if you don't want a minimum_cancellation_notice, you would expect to be able to set it to 0.days. However, that still gives you a one day minimum cancellation notice.

(Date.today - 0.days).future?
# => false

Instead of checking if the date is in the future, it should also return true if the date is today.

[seand7565]

Fixed with #178