Better deprecations for Spree::Core:: #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
test this please |
|
👍 |
| super | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
So this block is adding deprecation warnings on something that currently would just error? Is that a good thing?
There was a problem hiding this comment.
It tells programmers what and how to upgrade, rather than having to hunt down what is happening.
So I am 👍
There was a problem hiding this comment.
that seems reasonable to me. @magnusvk ?
|
retest this please |
gmacdougall
added a commit
that referenced
this pull request
May 12, 2015
Better deprecations for Spree::Core::
bbuchalter
pushed a commit
to bbuchalter/solidus
that referenced
this pull request
Jan 6, 2017
Switch order search to using starts over cont
JDutil
pushed a commit
to JDutil/solidus
that referenced
this pull request
Feb 6, 2020
Add TaxRate hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.