Remove translation from Spree::LineItem #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to [I assume] the Rails load order, it this translation prohibits include/prepend/extend decoration of Spree::LineItem as the locales aren’t loaded yet. I also believe this to be redundant, as there is a before_validation method to ensure the quantity is never less than 0 on #L15
|
I'm not sure I follow whats going wrong with your attempts to extend it, but I am 👍 as I see no reason to need the custom translation here. |
|
Nice catch. To reiterate, this Thanks very much @SebAshton 👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 18, 2016
Remove translation from Spree::LineItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to [what I assume is] the Rails load order, this hard code translation prohibits include/prepend/extend decoration of Spree::LineItem as the locales aren’t loaded yet.
I also believe this to be redundant, as there is a before_validation method to ensure the quantity is never less than 0 on Line 15