Taxon tree page fixes #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4d44b0
to
e342ecf
Compare
|
Yea, thanks @jhawthorn, this page needed time and attention. 👍 |
Now that the Taxon model can handle updating its own and children's permalink, this code is unnecessary. Also extracted the assignment of the permalink_part to the model.
992ead4
to
6d59560
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page was not in a good way and needed a number of fixes.
This also includes the cleanup from #835
If approved I would like to backport the admin mount path fix, "add child" button, and "add taxon" fix to the 2.1 branch, as the taxon page is essentially non-functional in that version currently. Updating permalinks automatically is a desirable, but too big for us to include in a patch release.