Improve i18n store credits #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys in use were renamed to be more consistent with the entire rest of the project. Use model name attribute where logical.
dc54ac8
to
7c542a6
Compare
|
for situations where ":" doesn't work well in a translation, we might want to start passing the other bits as params so people can customize them however they wish, instead of always value first. I'm still 👍 for this, though. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizies model attribute translation. Pulled a
:into a translation in case that doesn't work as well in other languages. Removed an unnecessary<br />from a translation and removed unnecessaryhtml.safeoptions. Alphabetized a part of thestore_creditsnamespace in the dictionary.Did not address the form in the section as it was handled in a different PR presently jhawthorn@e6f5a57. This is part of an ongoing effort to improve I18n usage as discussed in #735.