Improve I18n in shipping category views #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| <div data-hook="admin_shipping_category_form_fields"> | |||
| <div data-hook="name" class="field align-center"> | |||
| <%= label_tag :shipping_category_name, Spree.t(:name) %><br> | |||
| <%= f.text_field :name %> | |||
| <%= label_tag :shipping_category_name %><br> | |||
There was a problem hiding this comment.
I don't think this will pick up a translation
c56c99a
to
4c2f4ee
Compare
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 12, 2016
…iews Improve I18n in shipping category views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use model name and model attribute translation instead of generic translations.
This is part of an ongoing effort to improve I18n usage as discussed in #735.