removes :force attribute from params #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses solidusio#652 where a user was not able to update the inventory in the admin panel due to #permitted_stock_item_attributes not including :force as a valid parameter. I added the attribute `:backorderable` which allowed our test suite to pass, however I have concerns that I may be missing something here and was contemplating whether it would be best to add the attribute in core or strip out of the param after checking it. I went with stripping it out of the params. You can find the reference to attributes here https://github.com/solidusio/solidus/blob/e15ca73e8f7083633343f0678023695a96e24d31/core/lib/spree/permitted_attributes.rb#L94
ajkamel
force-pushed
the
ak-removes-force-from-param
branch
from
94c5325
to
13b78d0
Compare
|
Looks good to me 👍 Thanks |
|
Yea, looks good to me too, much appreciated @ajkamel 👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 15, 2016
removes :force attribute from params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses #652 where a user was not able to update the
inventory in the admin panel due to #permitted_stock_item_attributes not
including :force as a valid parameter.
I added the attribute
:backorderablewhich allowed our test suite topass, however I have concerns that I may be missing something here and
was contemplating whether it would be best to add the attribute in core
or strip out of the param after checking it. I went with stripping it
out of the params.
You can find the reference to attributes here
solidus/core/lib/spree/permitted_attributes.rb
Line 94 in e15ca73