Allow configuring Capybara's default_max_wait_time #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can swing it. 👍 |
|
I'm 👍 for this mostly because it ALSO allows us to jam it down as well. Which is nifty. |
Allows configuring Capybara.default_max_wait_time via ENV variable. Locally, these tests always pass for me with capybara's default of 2. But in a CI environment, it sometimes fails, only to show the expected HTML from capybara-screenshot. This also allows reducing the default_max_wait_time to try and debug issues (tests pass for me with 0.5 seconds locally).
jhawthorn
force-pushed
the
default_max_wait_time
branch
from
cd5df2b
to
092d9c4
Compare
jhawthorn
added a commit
that referenced
this pull request
Feb 16, 2016
Allow configuring Capybara's default_max_wait_time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been trying to avoid this commit, which increases this timeout on CI, because we shouldn't have to. No interaction in our admin should take more than 2 seconds to occur.
Though they don't ever take that long under normal circumstances, it certainly seems like they do sometimes on CircleCI. See
any
of
these
failures
which timeout, but have the expected content by the time capybara-screenshot saves a screenshot.
This also allows reducing the default_max_wait_time to try and debug issues (all tests pass for me with 0.5 seconds locally).