Use model translations in adjustment_reason view #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| <%= adjustment_reason.name %> | |||
| </td> | |||
| <td class="align-center"> | |||
| <%= Spree.t(adjustment_reason.active? ? :active : :inactive) %> | |||
| <%= Spree::AdjustmentReason.human_attribute_name(adjustment_reason.active? ? :active : :inactive) %> | |||
There was a problem hiding this comment.
I don't think this is an attribute name, it's translations for two of the values the attribute can have.
There was a problem hiding this comment.
I was iffy about this. active is an attribute on the model (a boolean) but inactive is not. I did add it in though to make this work obviously.
The AdjustmentReason model is used in translations in the index view.
Murph33
force-pushed
the
use_model_translation_adjustment_reason_index
branch
from
18aeb43
to
0286bea
Compare
|
👍 |
jhawthorn
added a commit
that referenced
this pull request
Feb 16, 2016
…_reason_index Use model translations in adjustment_reason view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdjustmentReason model is used in translations in the index view.
This is to make better use of I18n and to be nicer to non English speakers.
This is part of an ongoing issue being discussed in #735.