Remove all remaining references to JSTree

[graygilmore]

This commit continues the cleanup that was accomplished when we moved from JSTree to jQuery UI Sortable in this PR: #569

Closes #194

[Senjai]

👍

[jhawthorn]

Thank you Gray.

I believe there is also a api/app/views/spree/api/taxons/jstree.rabl file which can be removed.

There was some concern raised last time this was brought up that this is an incompatibility and should be deprecated instead. I feel otherwise and am fairly confident nobody would use these routes. The data format they return is only useful when using jstree (possibly only the really old version we had installed)

[graygilmore]

@jhawthorn thanks, forgot about those. Fixed the commit.

I had considered the incompatibility issue but considering the fact that we've nuked jstree from the project anyways it makes sense that this would need to be a customization for somebody to take on in their own project.

[jhawthorn]

👍

[cbrunsdon]

@jhawthorn I'm generally opposed to this as more people were using it than I expected (from a poke around of people/projects). I would want us to find a way to deprecate it for 1.2 and remove it at a later date.

Is there another way to get the same structure of data out of our public API?

[jhawthorn]

Is there another way to get the same structure of data out of our public API?

No, but it's a trivial transformation.

// /api/taxonomies/1/taxons/1/jstree
[{"data":"Bags","attr":{"id":3,"name":"Bags"},"state":"closed"},{"data":"Mugs","attr":{"id":4,"name":"Mugs"},"state":"closed"},{"data":"Clothing","attr":{"id":5,"name":"Clothing"},"state":"closed"}]

Compared to the proper route

// /api/taxonomies/1/taxons/1
{"id":1,"name":"Categories","pretty_name":"Categories","permalink":"categories","parent_id":null,"taxonomy_id":1,"taxons":[{"id":3,"name":"Bags","pretty_name":"Categories -\u003e Bags","permalink":"categories/bags","parent_id":1,"taxonomy_id":1},{"id":4,"name":"Mugs","pretty_name":"Categories -\u003e Mugs","permalink":"categories/mugs","parent_id":1,"taxonomy_id":1},{"id":5,"name":"Clothing","pretty_name":"Categories -\u003e Clothing","permalink":"categories/clothing","parent_id":1,"taxonomy_id":1}]}

Here's my go at a transform in js

$.map(data.taxons, function(t){
  return {"data": t.name, "attr": {"id": t.id, "name": t.name}, "state": "closed"};
})

[BenMorganIO]

👎 since API removals are a major change for people. Anyone who has an iOS or Android app using these endpoints are going to get stuck on previous versions of Solidus unless they code their own.

Maybe provide a gem for this so that way we don't leave anyone in the dust and just provide deprecation warnings that it'll be removed in 2.0?

[jhawthorn]

I'm still in favour of removing this as I don't expect anyone to use the jstree specific route of the api, but discussion seems to have stalled.

Closing this issue for now.