Legacy Promotions: Fix shipping promo application after state machine reload #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice I had to give the implementation method an argument, because RSpec stubs do not have the correct `arity`; and `state_machines` will send the event, resulting in an ArgumentError otherwise.
Some extensions rely on the default state machine being fully reloadable, and as long as we use solidus_legacy_promotions, the before_transition method `:apply_shipping_promotions` must survive a reload of the state machine. Rather than patching Spree::Order and adding the transition here, we add it where all the other default transitions are added: In the class methods of the order state machine.
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5797 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 718 719 +1
Lines 16939 16944 +5
=======================================
+ Hits 15063 15068 +5
Misses 1876 1876 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 19, 2024
|
Specs related only. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a flaky spec in
solidus_starter_frontend. Let me explain:solidus_legacy_promotionsadds aThe specs for
solidus_starter_frontendinclude one that tests correctly applied shipping promotions.But another spec in
solidus_starter_frontendreloads the state machine using the following mechanism:What this PR does is add the
apply_shipping_promotionbefore-transition hook directly to the default state machine, rather than evaling it into the order class, where it does not survice reloads of the checkout flow.