Move promotion translations to legacy_promotions #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5795 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 718 718
Lines 16939 16939
=======================================
Hits 15063 15063
Misses 1876 1876 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jun 18, 2024
tvdeyen
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the translations for promotions and promotion categories to the legacy_promotions gem. Additionally, it copies the translations for the orders component to the one created in
legacy_promotions, because the way translations work in components is not compatible with inheritance.