Mark flaky spec as flaky instead of sleep #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This marks the legacy promotions order index spec as flaky so that we get two retries if it fails. Better than just sending the process to sleep for a second.
7f52eff
to
52c8b7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5792 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 718 718
Lines 16939 16939
=======================================
Hits 15039 15039
Misses 1900 1900 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 14, 2024
|
TIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the legacy promotions order index spec as flaky so that we get two retries if it fails. Better than just sending the process to sleep for a second.
Closes #5782