Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec with synchronize #5784

Closed

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 12, 2024

Summary

This will keep clicking the Filter button until the promotions menu
appears. The problem this fixes is that a few milliseconds after
navigation, the JS controller that switches the filter bar out might not
have loaded.

Alternative fixes here:
#5782
#5783

It's cumbersome to find elements by CSS selectors to click them, and the
new admin has a few instances where we have no standalone label.
This will keep clicking the Filter button until the promotions menu
appears. The problem this fixes is that a few milliseconds after
navigation, the JS controller that switches the filter bar out might not
have loaded.

Alternative fixes here:
solidusio#5782
solidusio#5783
@mamhoff mamhoff marked this pull request as ready for review June 12, 2024 07:31
@mamhoff mamhoff requested a review from a team as a code owner June 12, 2024 07:31
@mamhoff
Copy link
Contributor Author

mamhoff commented Jun 12, 2024

This does not actually fix the problem, and we have a fix in #5783

@mamhoff mamhoff closed this Jun 12, 2024
@mamhoff mamhoff deleted the fix-flaky-spec-with-synchronize branch June 12, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant