Components registry safe reload #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
components-registry-safe-reload
branch
3 times, most recently
from
93a8d30
to
c1826d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5780 +/- ##
=======================================
Coverage 88.72% 88.73%
=======================================
Files 712 713 +1
Lines 16914 16924 +10
=======================================
+ Hits 15007 15017 +10
Misses 1907 1907 ☔ View full report in Codecov by Sentry. |
elia
reviewed
Jun 7, 2024
mamhoff
force-pushed
the
components-registry-safe-reload
branch
2 times, most recently
from
83ef1ac
to
4005895
Compare
tvdeyen
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Loving where this is going, but we should give caching a try IMO.
The Rails guide even says:
Bottom line: do not cache reloadable classes or modules.
Is there a way to use Zeitwerk for the cache? 🤔
tvdeyen
approved these changes
Jun 12, 2024
This adds a new `ComponentRegistry` class that allows: - setting component classes as strings (to allow for easy reloading) - getting nice errors when requesting components that don't exist - getting nice errors when setting a component to a non-existing class It also moves some of the logic from `SolidusAdmin::Configuration` into a separate class. I've decided not to add memoization here as I'm not sure this would make a giant difference performance-wise, and also the Rails Guide on Reloading constants very clearly says: ``` Bottom line: do not cache reloadable classes or modules. ```
mamhoff
force-pushed
the
components-registry-safe-reload
branch
from
4005895
to
0408942
Compare
|
Rebased on |
elia
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a Zeitwerk world, we can't use reloadable constant in initializers.
This moves the constantization of the names of components into a new
ComponentRegistryclass.This PR is build on top of #5779 so that the theory can directly be tested. Really relevant is only the second commit here.