App configuration: Use SimpleOrderContents by default #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
reviewed
Jun 5, 2024
mamhoff
force-pushed
the
use-simple-order-contents-by-default
branch
from
bbfc9a5
to
8199988
Compare
With the null promotion configuration in place, we can't use the legacy Spree::OrderContents class, as that makes references to the legacy promotion system. See solidusio#5755
This class directly references Spree::PromotionHandler::Cart, and thus needs to live in the legacy_promotions gem. If you inherit from this class, and it happens to not be available after upgrading, please add ``` gem "solidus_legacy_promotions" ``` to your Gemfile.
mamhoff
force-pushed
the
use-simple-order-contents-by-default
branch
from
8199988
to
4438744
Compare
github-actions
bot
added
the
changelog:solidus_backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 711 711
Lines 16885 16885
=======================================
Hits 15007 15007
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Jun 7, 2024
tvdeyen
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the null promotion configuration in place, we can't use the legacy Spree::OrderContents class, as that makes references to the legacy promotion system.
See #5755