Fix search by variant on stock items #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
nvandoorn
changed the title
This was referenced Feb 13, 2024
nvandoorn
commented
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5660 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 685 685
Lines 16408 16408
=======================================
Hits 14530 14530
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Feb 13, 2024
tvdeyen
added
backport-v4.2
Before we fix this bug, we should reproduce it in a feature spec. Co-authored-by: An Stewart <[email protected]> Co-authored-by: Adam Mueller <[email protected]>
This "fixes" the variant scope issue but I'm not sure it's the solution we want. I suppose it depends if ordering by sku is important here. Co-authored-by: An Stewart <[email protected]>
nvandoorn
force-pushed
the
5506-fix-search-by-variant-on-stock-items
branch
from
f8ed5b0
to
c4bd75a
Compare
jarednorman
approved these changes
Feb 13, 2024
|
Thanks, @nvandoorn! |
This was referenced Feb 14, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch fixes the invalid SQL error that occurs when filtering stock locations by variant (#5506). The implementation changes are still a work in progress, so this pull request is in draft, but I wanted to put this up now so other contributors can see/use the feature spec.
Checklist
The following are mandatory for all PRs:
The following are not always needed: