[4.1] Fix latest rubocop offenses #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed with
rubocop -a
Using
rubocop -A
and verified they are safe.
Cherry Picked from bc3944d Co-Authored-By: Elia Schito <[email protected]>
We have tasks that are not needing the Rails environment for builds and such that are not in the Rails app Rubocop flags those by mistake because it does not know we are not an app, but an engine.
github-actions
bot
added
changelog:solidus_api
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v4.1 #5654 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 563 563
Lines 13883 13883
=======================================
Hits 12320 12320
Misses 1563 1563 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #5653 but for 4.1 branch