Menu item should not match url if match_path is set

[sascha-karnatz]

Summary

The menu item should not match the url if a match_path prevents this behavior. Previously the match_path method went truthy, if the url of the menu item started with the same url as the request regardless of the given match_path - configuration.

Example

The regex in the match_path of menu item 1 should highlight only if the url ends with "bar":

Menu Item 1: {url: '/foo/bar', match_path: %r{/bar$/} } 
Menu Item 2: {url: '/foo/bar_baz'}
Request: /foo/bar_baz

In the prevous implementation both menu items got highlighted, because they started with the same url. In the implemation of this Pull Request only the second menu item will be highlighted.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• ✅ I have added automated tests to cover my changes.

[tvdeyen]

Thanks. Makes sense to me. The test failures are unrelated. Fix is in #5644

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb80c3a) 88.55% compared to head (26fa1c1) 88.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5643   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         685      685           
  Lines       16407    16408    +1     
=======================================
+ Hits        14529    14530    +1     
  Misses       1878     1878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kennyadsl]

👍

[kennyadsl]

@tvdeyen I'm not sure about all those backport labels. The changed code was introduced with #5309, merged on v4.2

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	v4.2
✅	v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[kennyadsl]

EDIT: you are already on that. ❤️

[tvdeyen]

EDIT: you are already on that. ❤️

Yes, thankfully @sascha-karnatz pointed me to it as well