Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.2] Allow "sqlite3" as ENV["DB"] #5613

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[v4.2] Allow "sqlite3" as ENV["DB"] #5613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow "sqlite3" as ENV["DB"] 
Since solidus-orbs-extension v0.10.0, the CI runner will set the ENV var
for sqlite to be `sqlite3`, which currently raises an error.
  • Loading branch information
@mamhoff
mamhoff committed Jan 23, 2024
commit 807048530ac014fcf5bb6aa0e45d6e698035ca23
2 changes: 1 addition & 1 deletion core/lib/generators/spree/dummy/templates/rails/database.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
'mysql'
when 'postgres', 'postgresql'
'postgres'
when 'sqlite', '', nil
when /sqlite3?/, '', nil
'sqlite'
else
raise "Invalid DB specified: #{ENV['DB']}"
Expand Down