[v4.3] Theme selection for Solidus Admin: Use spree routing proxy #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When using the navigation from a gem that isolates its namespace in such a way that the default route helper is not spree, this partial fails to render with an undefined method error. This can easily be fixed by prefixing the route helper with Solidus' routing proxy. This is the same problem and solution as #5599, just for the theme selection partial that is used when using the current admin (rather than the new one). (cherry picked from commit f4c96a8)
github-actions
bot
added
the
changelog:solidus_backend
3 tasks
adammathys
approved these changes
Jan 18, 2024
spaghetticode
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.3:Questions ?
Please refer to the Backport tool documentation