Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore coverage tracking #5580

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Restore coverage tracking #5580

merged 6 commits into from
Jan 3, 2024

Conversation

elia
Copy link
Member

@elia elia commented Jan 3, 2024

Summary

At some point a few months ago it stopped working.

Merge the coverage command and job and avoid env variables that seem to not work properly and bump the ruby version.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jan 3, 2024
@elia elia requested a review from a team as a code owner January 3, 2024 10:48
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 206 lines in your changes are missing coverage. Please review.

Comparison is base (9413383) 88.46% compared to head (4465f02) 88.66%.
Report is 267 commits behind head on main.

Files Patch % Lines
admin/lib/solidus_admin/install_tailwindcss.rb 0.00% 72 Missing ⚠️
...ib/generators/solidus/install/install_generator.rb 19.04% 17 Missing ⚠️
...erators/solidus_admin/install/install_generator.rb 0.00% 11 Missing ⚠️
admin/lib/solidus_admin/configuration.rb 72.00% 7 Missing ⚠️
...s/spree/payment_method/simple_bogus_credit_card.rb 33.33% 6 Missing ⚠️
...ntrollers/solidus_admin/option_types_controller.rb 77.27% 5 Missing ⚠️
...ollers/solidus_admin/payment_methods_controller.rb 81.48% 5 Missing ⚠️
...controllers/solidus_admin/taxonomies_controller.rb 77.27% 5 Missing ⚠️
.../controllers/solidus_admin/addresses_controller.rb 57.14% 3 Missing ⚠️
...ers/solidus_admin/adjustment_reasons_controller.rb 84.21% 3 Missing ⚠️
... and 39 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5580      +/-   ##
==========================================
+ Coverage   88.46%   88.66%   +0.20%     
==========================================
  Files         633      683      +50     
  Lines       15160    16299    +1139     
==========================================
+ Hits        13411    14452    +1041     
- Misses       1749     1847      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia elia force-pushed the elia/restore-coverage-uploads branch from 0d6e2e1 to 4465f02 Compare January 3, 2024 13:29
@elia elia merged commit 4c635fe into main Jan 3, 2024
12 of 13 checks passed
@elia elia deleted the elia/restore-coverage-uploads branch January 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant