Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the down step of the DropDeprecatedAddressIdFromShipments migration #5557

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

DanielePalombo
Copy link
Contributor

@DanielePalombo DanielePalombo commented Dec 19, 2023

Summary

bin/rails db:rollback

fails with

Caused by:
ArgumentError: wrong number of arguments (given 2, expected 3)

This commit is fixing the rollback

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@DanielePalombo DanielePalombo requested a review from a team as a code owner December 19, 2023 11:07
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 19, 2023
`bin/rails db:rollback`

fails with

```
Caused by:
ArgumentError: wrong number of arguments (given 2, expected 3)
```
This commit is fixing the rollback
@elia elia merged commit e281b6c into solidusio:main Dec 19, 2023
8 checks passed
@elia elia changed the title Fix down migration Fix the down step of the DropDeprecatedAddressIdFromShipments migration Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants