Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add stock_items/edit modal component #5543

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Dec 6, 2023

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema rainerdema changed the title [admin] stock-edit modal [Admin] Add stock_items/edit modal component Dec 7, 2023
@elia elia force-pushed the elia+rainer/admin/stock-edit branch from ac4ccc5 to c6ae12c Compare December 11, 2023 15:36
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Dec 11, 2023
rainerdema and others added 9 commits December 11, 2023 17:30
This commit introduces a new `ui/switch_field` component, which
utilizes the `ui/switch` component:
It includes a hidden input to facilitate the passing of the switch
parameter
in forms.

Additionally, a toggle field generator has been added to the main field
component.

Co-Authored-By: Elia Schito <[email protected]>
This initializer configures logging for View Components.
In the development and test environments, it subscribes
to the 'render.view_component' event, and logs the
rendered component's name and duration in milliseconds.

https://viewcomponent.org/guide/instrumentation.html#viewing-instrumentation-sums-in-the-browser-developer-tools

Co-Authored-By: Elia Schito <[email protected]>
@elia elia force-pushed the elia+rainer/admin/stock-edit branch from d551e1b to 29e3134 Compare December 11, 2023 16:39
@github-actions github-actions bot removed the changelog:solidus_core Changes to the solidus_core gem label Dec 11, 2023
@elia elia marked this pull request as ready for review December 12, 2023 09:29
@elia elia requested a review from a team as a code owner December 12, 2023 09:29
@elia elia requested review from rainerdema and removed request for a team December 12, 2023 09:29
@elia elia merged commit 1059c6c into main Dec 12, 2023
8 checks passed
@elia elia deleted the elia+rainer/admin/stock-edit branch December 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants