Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Add index pages for the settings / shipping area #5536

Merged
merged 4 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add an index page for shipping categories
  • Loading branch information
elia committed Dec 5, 2023
commit cccd18cfa6e8c17bf733ee2e167304d062da0ad6
1 change: 1 addition & 0 deletions admin/app/components/solidus_admin/shipping/component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def initialize(current_class:)
def tabs
{
Spree::ShippingMethod => solidus_admin.shipping_methods_path,
Spree::ShippingCategory => solidus_admin.shipping_categories_path,
}
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<%= render component('shipping').new(current_class: Spree::ShippingCategory) do |layout| %>
<% layout.with_actions do %>
<%= render component("ui/button").new(
tag: :a,
text: t('.add'),
href: spree.new_admin_shipping_category_path,
icon: "add-line",
class: "align-self-end w-full",
) %>
<% end %>
<%= render component('ui/table').new(
id: stimulus_id,
data: {
class: Spree::ShippingCategory,
rows: @page.records,
url: ->(shipping_category) { spree.edit_admin_shipping_category_path(shipping_category) },
prev: prev_page_path,
next: next_page_path,
columns: columns,
batch_actions: batch_actions,
},
search: {
name: :q,
value: params[:q],
url: solidus_admin.shipping_categories_path,
searchbar_key: :name_or_description_cont,
filters: filters,
scopes: scopes,
},
) %>
<% end %>
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# frozen_string_literal: true

class SolidusAdmin::ShippingCategories::Index::Component < SolidusAdmin::BaseComponent
include SolidusAdmin::Layout::PageHelpers

def initialize(page:)
@page = page
end

def title
Spree::ShippingCategory.model_name.human.pluralize
end

def prev_page_path
solidus_admin.url_for(**request.params, page: @page.number - 1, only_path: true) unless @page.first?
end

def next_page_path
solidus_admin.url_for(**request.params, page: @page.next_param, only_path: true) unless @page.last?
end

def batch_actions
[
{
display_name: t('.batch_actions.delete'),
action: solidus_admin.shipping_categories_path,
method: :delete,
icon: 'delete-bin-7-line',
},
]
end

def filters
[]
end

def scopes
[]
end

def columns
[
:name
]
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
en:
add: 'Add new'
batch_actions:
delete: 'Delete'
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# frozen_string_literal: true

module SolidusAdmin
class ShippingCategoriesController < SolidusAdmin::BaseController
include SolidusAdmin::ControllerHelpers::Search

def index
shipping_categories = apply_search_to(
Spree::ShippingCategory.order(id: :desc),
param: :q,
)

set_page_and_extract_portion_from(shipping_categories)

respond_to do |format|
format.html { render component('shipping_categories/index').new(page: @page) }
end
end

def destroy
@shipping_category = Spree::ShippingCategory.find_by!(id: params[:id])

Spree::ShippingCategory.transaction { @shipping_category.destroy }

flash[:notice] = t('.success')
redirect_back_or_to shipping_categories_path, status: :see_other
end

private

def load_shipping_category
@shipping_category = Spree::ShippingCategory.find_by!(id: params[:id])
authorize! action_name, @shipping_category
end

def shipping_category_params
params.require(:shipping_category).permit(:shipping_category_id, permitted_shipping_category_attributes)
end
end
end
6 changes: 6 additions & 0 deletions admin/config/locales/shipping_categories.en.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
en:
solidus_admin:
shipping_categories:
title: "Shipping Categories"
destroy:
success: "Shipping categories were successfully removed."
1 change: 1 addition & 0 deletions admin/config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,5 @@
admin_resources :payment_methods, only: [:index, :destroy], sortable: true
admin_resources :stock_items, only: [:index]
admin_resources :shipping_methods, only: [:index, :destroy]
admin_resources :shipping_categories, only: [:index, :destroy]
end
22 changes: 22 additions & 0 deletions admin/spec/features/shipping_categories_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# frozen_string_literal: true

require 'spec_helper'

describe "Shipping Categories", :js, type: :feature do
before { sign_in create(:admin_user, email: '[email protected]') }

it "lists shipping categories and allows deleting them" do
create(:shipping_category, name: "Default-shipping")

visit "/admin/shipping_categories"
expect(page).to have_content("Default-shipping")
expect(page).to be_axe_clean

select_row("Default-shipping")
click_on "Delete"
expect(page).to have_content("Shipping categories were successfully removed.")
expect(page).not_to have_content("Default-shipping")
expect(Spree::ShippingCategory.count).to eq(0)
expect(page).to be_axe_clean
end
end