Allow to choose a custom routes' mount point during install #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
kennyadsl
force-pushed
the
kennyadsl/fix-routes-doc
branch
from
788eaeb
to
5928b65
Compare
|
@rainerdema @elia are you familiar with the failing linting job? It doesn't seem to be related to my changes, can you help me? |
|
@kennyadsl Most likely an update in rubocop that made invalid stuff that was previously ok |
elia
force-pushed
the
kennyadsl/fix-routes-doc
branch
from
5928b65
to
a49d540
Compare
|
@kennyadsl the CI should be ok after #5535 is merged |
Since we moved the frontend as an injectable templating system, there are some manual steps to do to make the application work when a user wants to change the mount point of where Solidus is installed. With this change, along with solidusio/solidus_starter_frontend#359, we allow the user to select the mount point during the install, and all the changes required are handled by the install script.
elia
force-pushed
the
kennyadsl/fix-routes-doc
branch
from
a49d540
to
f4f3950
Compare
|
@elia @rainerdema checks are green, can you review it when you have a moment, please? (No hurry) |
jarednorman
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we moved the frontend as an injectable templating system, there are some manual steps to do to make the application work when a user wants to change the mount point of where Solidus is installed.
With this change, along with solidusio/solidus_starter_frontend#359, we allow the user to select the mount point during the installation, and all the changes required are handled by the install script.
Related PRs
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: